Add plugin-pyenv as an available function for fish #3
Conversation
There was a problem hiding this comment.
How willing would you be to test a rewrite I made a few months ago? It's available here: https://github.com/oh-my-fish/plugin-pyenv/tree/rehab
|
|
||
| ## Usage | ||
|
|
||
| Just add the following line in your ```config.fish``` file: |
There was a problem hiding this comment.
The beauty of plugins is them being able to just work out of the box, with the least possible being left up to the user. That means the init function of a plugin does all the witchery.
There was a problem hiding this comment.
Totally agree. I did not find how to create this init. Since it is possible, this function may do that easier for users.
|
|
||
| function pyenv-init --description "Pyenv initialization script for fish shell" | ||
|
|
||
| # Checks if directories already exists. If not, creates then |
There was a problem hiding this comment.
Doesn't pyenv take care of this? And is it really necessary to check every time a new session is created?
There was a problem hiding this comment.
It could also be solved by the init function. It is not necessary to run that on every new session.
| set --query PYENV_ROOT; or set --local PYENV_ROOT $HOME/.pyenv | ||
|
|
||
| # Appends PYENV_ROOT directories to PATH variable | ||
| set PATH $PYENV_ROOT/shims $PYENV_ROOT/bin $PATH |
There was a problem hiding this comment.
Looks like this might be something related to making pyenv command available, but my experience tells me shims suffices. Not sure how it works on OSs other than OS X thou.
There was a problem hiding this comment.
I really do not know this behavior in other OSs. I just keep the way this plugin did.
|
The branch rehab seems really complete for me. Is there any problem at why it is not in the master? It would be a good version of an official plugin. |
|
All it lacks is a proper README.md and some test drive on a GNU/Linux box, which I could do later tonight. |
|
And thank you for testing it! Much appreciated 👍 |
|
The branch rehab also works great for me. Thanks! |
|
Thanks for confirming it works, fellas! Last night I had a chance to test it on a Linux box. It works there too only after a few tweaks. So rehab seems to work regardlessly of the install method – package manager or pyenv-installer. But it still lacks a proper README.md. And I think we can gain from the one of this very PR. What do you think, @pantuza? |
|
@scorphus I think that would be awesome. If you need any help, let me know! |
|
Hey, dear fellas, @brunobbbs and @pantuza! I've updated the Thanks! |
This pull request has the following contributions: